- Replace print() statements with logging module in all test files
- Use consistent logger naming: bipauto.tests.<test_name>
- Apply unified log format: [%(levelname)s] %(name)s: %(message)s
- Migrates test_extractor_real.py, test_login.py, test_auth_config.py, test_extractor_component.py
This change ensures consistent log output format between test files and utils modules, matching the existing bipauto.* logger hierarchy.
Add centralized logging utility and optional logger parameters to all
core functions for better observability and debugging capabilities.
New modules:
- utils/logging.py: Centralized logger configuration with console
and optional file handlers
Enhanced features:
- Added optional logger parameter to all extractor_core functions
- Added logger support to extractor, excel_converter, and auth modules
- Functions remain silent when logger=None (backward compatible)
- Improved environment variable validation in test files
Documentation:
- Added discrete_material_plan_extractor_core.md with complete API
reference and usage patterns
Benefits:
- Consistent logging format across all components
- Optional debug output for troubleshooting
- No breaking changes - fully backward compatible
- Better error messages and validation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add comprehensive post-processing features to convert downloaded Excel files
into structured data and merge them into a single output file.
New modules:
- extractor_core.py: Stateless pure functions for web operations
- excel_converter.py: Excel to DataFrame conversion utility
- tests/test_extractor_real.py: Real data extraction test suite
Enhanced features:
- post_process_downloads(): Convert and merge multiple Excel files
- extract_and_process(): Complete workflow in single call
- cleanup_temp_files(): Optional cleanup of temporary downloaded files
- Field name mapping for standardized output columns
Dependencies:
- pandas>=2.0.0 for data manipulation
- openpyxl>=3.1.0 for Excel file handling
Documentation:
- Updated CLAUDE.md with new module references
- Added API documentation for extractor components
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove DiscreteMaterialPlanExtractor class (stateful)
- Replace with pure functions: chunk_order_ids, get_login_url, extract_batch, etc.
- All functions are stateless, accept explicit parameters
- Caller manages browser/session lifecycle (consistent with extractor_core.py)
- Lower coupling: no direct dependency on utils.auth.login
- Update tests to match new function signatures
Breaking Changes:
- DiscreteMaterialPlanExtractor class removed
- Use extract_and_post_process() or extract_from_file() instead of class methods
- Caller must manage browser session before calling extractor functions
- Create DiscreteMaterialPlanExtractor class orchestrating web operations and post-processing
- Implement extract_and_process() combining download + Excel conversion
- Implement post_process_downloads() using ExcelConverter for merge
- Add extract_from_file() convenience function for file-based ID input
- Add component test file verifying class structure and methods
- Follow existing patterns: verbose logging, explicit parameters, English comments
- Document ERP_AUTO_CLOSE_BROWSER environment variable
- This variable is used in test scripts to control browser auto-close behavior
- Ensures template is complete with all used variables
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Provide template for required environment variables
- Document all configuration options
- Help users set up their local environment
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix return value from 2-tuple to 4-tuple (browser, context, page, main_frame)
- Correct function signature to match actual implementation
- Documentation now matches the actual API
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Clarify that auth module is pure with no environment access
- Document URL construction pattern for callers
- Update module structure documentation
- Emphasize caller responsibility for configuration
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add explicit check for ERP_URL environment variable
- Prevent AttributeError when ERP_URL is not set
- Provide clear error message for missing configuration
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Import only login and logout (remove close_session)
- Add explicit URL construction before login call
- Pass all required parameters to login()
- Replace close_session() with direct context.close() and browser.close()
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove close_session() wrapper function entirely
- Callers now directly manage browser/context lifecycle
- Reduces module to pure authentication functions only
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove all os.getenv() calls from login() function
- Remove URL construction logic (caller provides complete URL)
- Add parameter validation with clear error messages
- Function is now pure with no side effects
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove os, dotenv, and pathlib imports
- Remove module-level environment setup code
- Prepare for pure function implementation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Create detailed step-by-step implementation plan
- 9 tasks covering all refactoring aspects
- TDD approach with explicit verification steps
- Include test updates and documentation changes
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Document decoupling approach for utils/auth.py
- Remove all environment variable dependencies
- Make login() a pure function with required parameters
- Remove close_session() function
- Provide migration guide for test scripts
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Document project overview and architecture
- Add development environment setup instructions
- Specify environment configuration requirements
- Document module structure and page interaction patterns
- Add common commands for testing
- Establish code conventions including mandatory test coverage for new components
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Configured standard Python .gitignore with patterns for virtual environments, compiled files, packages, testing, IDEs, and AI agent directories.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
