refactor: update login() signature to require all parameters
- Remove default values for username, password, url, headless, ignore_https_errors - Update docstring to reflect required parameters - Maintain backward compatibility with 4-tuple return value Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -7,11 +7,11 @@ from playwright.sync_api import Playwright, Browser, BrowserContext, Page, Frame
|
|||||||
|
|
||||||
def login(
|
def login(
|
||||||
playwright: Playwright,
|
playwright: Playwright,
|
||||||
username: str = None,
|
username: str,
|
||||||
password: str = None,
|
password: str,
|
||||||
url: str = None,
|
url: str,
|
||||||
headless: bool = None,
|
headless: bool,
|
||||||
ignore_https_errors: bool = None,
|
ignore_https_errors: bool,
|
||||||
verbose: bool = True,
|
verbose: bool = True,
|
||||||
) -> tuple[Browser, BrowserContext, Page, Frame]:
|
) -> tuple[Browser, BrowserContext, Page, Frame]:
|
||||||
"""
|
"""
|
||||||
@@ -19,12 +19,12 @@ def login(
|
|||||||
|
|
||||||
Args:
|
Args:
|
||||||
playwright: Playwright instance
|
playwright: Playwright instance
|
||||||
username: Username (default read from environment variable ERP_USERNAME)
|
username: Username (required)
|
||||||
password: Password (default read from environment variable ERP_PASSWORD)
|
password: Password (required)
|
||||||
url: Login page URL (default read from environment variable ERP_URL)
|
url: Complete login page URL (required)
|
||||||
headless: Whether to use headless mode (default read from environment variable ERP_HEADLESS)
|
headless: Whether to use headless mode (required)
|
||||||
ignore_https_errors: Whether to ignore HTTPS errors (default read from environment variable ERP_IGNORE_HTTPS_ERRORS)
|
ignore_https_errors: Whether to ignore HTTPS errors (required)
|
||||||
verbose: Whether to print detailed logs
|
verbose: Whether to print detailed logs (default: True)
|
||||||
|
|
||||||
Returns:
|
Returns:
|
||||||
tuple: (browser, context, page, main_frame)
|
tuple: (browser, context, page, main_frame)
|
||||||
|
|||||||
Reference in New Issue
Block a user