From 9fe6cfe8e1e04a316acb250c8c66776b619434bc Mon Sep 17 00:00:00 2001 From: Misaka_Company Date: Fri, 27 Mar 2026 12:24:57 +0800 Subject: [PATCH] refactor: update login() signature to require all parameters - Remove default values for username, password, url, headless, ignore_https_errors - Update docstring to reflect required parameters - Maintain backward compatibility with 4-tuple return value Co-Authored-By: Claude Sonnet 4.6 --- utils/auth.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/utils/auth.py b/utils/auth.py index 8749b0c..e806f87 100644 --- a/utils/auth.py +++ b/utils/auth.py @@ -7,11 +7,11 @@ from playwright.sync_api import Playwright, Browser, BrowserContext, Page, Frame def login( playwright: Playwright, - username: str = None, - password: str = None, - url: str = None, - headless: bool = None, - ignore_https_errors: bool = None, + username: str, + password: str, + url: str, + headless: bool, + ignore_https_errors: bool, verbose: bool = True, ) -> tuple[Browser, BrowserContext, Page, Frame]: """ @@ -19,12 +19,12 @@ def login( Args: playwright: Playwright instance - username: Username (default read from environment variable ERP_USERNAME) - password: Password (default read from environment variable ERP_PASSWORD) - url: Login page URL (default read from environment variable ERP_URL) - headless: Whether to use headless mode (default read from environment variable ERP_HEADLESS) - ignore_https_errors: Whether to ignore HTTPS errors (default read from environment variable ERP_IGNORE_HTTPS_ERRORS) - verbose: Whether to print detailed logs + username: Username (required) + password: Password (required) + url: Complete login page URL (required) + headless: Whether to use headless mode (required) + ignore_https_errors: Whether to ignore HTTPS errors (required) + verbose: Whether to print detailed logs (default: True) Returns: tuple: (browser, context, page, main_frame)