fix: disable TLS encryption by default to avoid ServerName IP address warning
- Set encrypt: false as default for SQL Server connections - Fixes DEP0123 deprecation warning when connecting via IP address (VPN tunnel) - trustServerCertificate option still configurable via environment variable - Affects 6 files: sql-server.ts, bip-users-dao.ts, database/index.ts, database/data-source.ts, cleaner-handler.ts, validation-handler.ts
This commit is contained in:
@@ -28,7 +28,7 @@ async function getDatabaseService(): Promise<MySqlService | SqlServerService> {
|
|||||||
password: process.env.DB_PASSWORD || '',
|
password: process.env.DB_PASSWORD || '',
|
||||||
database: process.env.DB_NAME || '',
|
database: process.env.DB_NAME || '',
|
||||||
options: {
|
options: {
|
||||||
encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
|
encrypt: false,
|
||||||
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
@@ -110,7 +110,7 @@ export function registerCleanerHandlers(): void {
|
|||||||
url: erpUrl,
|
url: erpUrl,
|
||||||
username: erpUsername,
|
username: erpUsername,
|
||||||
password: erpPassword,
|
password: erpPassword,
|
||||||
headless: true
|
headless: input.headless ?? true
|
||||||
})
|
})
|
||||||
|
|
||||||
log.info('Logging in to ERP...')
|
log.info('Logging in to ERP...')
|
||||||
|
|||||||
@@ -67,7 +67,7 @@ async function getValidationDatabaseService(): Promise<MySqlService | SqlServerS
|
|||||||
password: process.env.DB_PASSWORD || '',
|
password: process.env.DB_PASSWORD || '',
|
||||||
database: process.env.DB_NAME || '',
|
database: process.env.DB_NAME || '',
|
||||||
options: {
|
options: {
|
||||||
encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
|
encrypt: false,
|
||||||
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -40,7 +40,7 @@ function buildDataSourceOptions(): DataSourceOptions {
|
|||||||
password: process.env.DB_PASSWORD || '',
|
password: process.env.DB_PASSWORD || '',
|
||||||
database: process.env.DB_NAME || '',
|
database: process.env.DB_NAME || '',
|
||||||
options: {
|
options: {
|
||||||
encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
|
encrypt: false,
|
||||||
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
||||||
},
|
},
|
||||||
...commonOptions
|
...commonOptions
|
||||||
|
|||||||
@@ -57,7 +57,7 @@ export function createSqlServerConfig(): SqlServerConfig {
|
|||||||
password: process.env.DB_PASSWORD || '',
|
password: process.env.DB_PASSWORD || '',
|
||||||
database: process.env.DB_NAME || '',
|
database: process.env.DB_NAME || '',
|
||||||
options: {
|
options: {
|
||||||
encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
|
encrypt: false,
|
||||||
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -35,7 +35,7 @@ export class SqlServerService implements IDatabaseService {
|
|||||||
password: this.config.password,
|
password: this.config.password,
|
||||||
database: this.config.database,
|
database: this.config.database,
|
||||||
options: {
|
options: {
|
||||||
encrypt: this.config.options?.encrypt ?? true,
|
encrypt: this.config.options?.encrypt ?? false,
|
||||||
trustServerCertificate: this.config.options?.trustServerCertificate ?? false
|
trustServerCertificate: this.config.options?.trustServerCertificate ?? false
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -77,7 +77,7 @@ export class BIPUsersDAO {
|
|||||||
password: process.env.DB_PASSWORD || '',
|
password: process.env.DB_PASSWORD || '',
|
||||||
database: process.env.DB_NAME || '',
|
database: process.env.DB_NAME || '',
|
||||||
options: {
|
options: {
|
||||||
encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
|
encrypt: false,
|
||||||
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|||||||
Reference in New Issue
Block a user