From 2f5dc7607d62fa7ce4e89fce6095571373f3ef33 Mon Sep 17 00:00:00 2001
From: Misaka_Company <pengqiangqiang0@gmail.com>
Date: Wed, 4 Mar 2026 16:53:58 +0800
Subject: [PATCH] fix: disable TLS encryption by default to avoid ServerName IP
 address warning

- Set encrypt: false as default for SQL Server connections
- Fixes DEP0123 deprecation warning when connecting via IP address (VPN tunnel)
- trustServerCertificate option still configurable via environment variable
- Affects 6 files: sql-server.ts, bip-users-dao.ts, database/index.ts,
  database/data-source.ts, cleaner-handler.ts, validation-handler.ts
---
 src/main/ipc/cleaner-handler.ts           | 4 ++--
 src/main/ipc/validation-handler.ts        | 2 +-
 src/main/services/database/data-source.ts | 2 +-
 src/main/services/database/index.ts       | 2 +-
 src/main/services/database/sql-server.ts  | 2 +-
 src/main/services/user/bip-users-dao.ts   | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/main/ipc/cleaner-handler.ts b/src/main/ipc/cleaner-handler.ts
index 5038b11..ca056aa 100644
--- a/src/main/ipc/cleaner-handler.ts
+++ b/src/main/ipc/cleaner-handler.ts
@@ -28,7 +28,7 @@ async function getDatabaseService(): Promise<MySqlService | SqlServerService> {
       password: process.env.DB_PASSWORD || '',
       database: process.env.DB_NAME || '',
       options: {
-        encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
+        encrypt: false,
         trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
       }
     })
@@ -110,7 +110,7 @@ export function registerCleanerHandlers(): void {
             url: erpUrl,
             username: erpUsername,
             password: erpPassword,
-            headless: true
+            headless: input.headless ?? true
           })
 
           log.info('Logging in to ERP...')
diff --git a/src/main/ipc/validation-handler.ts b/src/main/ipc/validation-handler.ts
index 08a14d7..1e2bcca 100644
--- a/src/main/ipc/validation-handler.ts
+++ b/src/main/ipc/validation-handler.ts
@@ -67,7 +67,7 @@ async function getValidationDatabaseService(): Promise<MySqlService | SqlServerS
       password: process.env.DB_PASSWORD || '',
       database: process.env.DB_NAME || '',
       options: {
-        encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
+        encrypt: false,
         trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
       }
     })
diff --git a/src/main/services/database/data-source.ts b/src/main/services/database/data-source.ts
index 9e3a284..cca48cb 100644
--- a/src/main/services/database/data-source.ts
+++ b/src/main/services/database/data-source.ts
@@ -40,7 +40,7 @@ function buildDataSourceOptions(): DataSourceOptions {
       password: process.env.DB_PASSWORD || '',
       database: process.env.DB_NAME || '',
       options: {
-        encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
+        encrypt: false,
         trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
       },
       ...commonOptions
diff --git a/src/main/services/database/index.ts b/src/main/services/database/index.ts
index c8b5bf4..a365352 100644
--- a/src/main/services/database/index.ts
+++ b/src/main/services/database/index.ts
@@ -57,7 +57,7 @@ export function createSqlServerConfig(): SqlServerConfig {
     password: process.env.DB_PASSWORD || '',
     database: process.env.DB_NAME || '',
     options: {
-      encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
+      encrypt: false,
       trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
     }
   }
diff --git a/src/main/services/database/sql-server.ts b/src/main/services/database/sql-server.ts
index 848c292..1f9c255 100644
--- a/src/main/services/database/sql-server.ts
+++ b/src/main/services/database/sql-server.ts
@@ -35,7 +35,7 @@ export class SqlServerService implements IDatabaseService {
         password: this.config.password,
         database: this.config.database,
         options: {
-          encrypt: this.config.options?.encrypt ?? true,
+          encrypt: this.config.options?.encrypt ?? false,
           trustServerCertificate: this.config.options?.trustServerCertificate ?? false
         }
       }
diff --git a/src/main/services/user/bip-users-dao.ts b/src/main/services/user/bip-users-dao.ts
index 5355cba..a900223 100644
--- a/src/main/services/user/bip-users-dao.ts
+++ b/src/main/services/user/bip-users-dao.ts
@@ -77,7 +77,7 @@ export class BIPUsersDAO {
         password: process.env.DB_PASSWORD || '',
         database: process.env.DB_NAME || '',
         options: {
-          encrypt: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes',
+          encrypt: false,
           trustServerCertificate: process.env.DB_TRUST_SERVER_CERTIFICATE === 'yes'
         }
       })