From fa33bee3e1edbd5f4a1be62f9b81f1d73494f8b2 Mon Sep 17 00:00:00 2001 From: Misaka_Company Date: Fri, 27 Mar 2026 12:45:56 +0800 Subject: [PATCH] refactor: update test_login.py to use new auth API - Import only login and logout (remove close_session) - Add explicit URL construction before login call - Pass all required parameters to login() - Replace close_session() with direct context.close() and browser.close() Co-Authored-By: Claude Sonnet 4.6 --- tests/test_login.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/test_login.py b/tests/test_login.py index 9b58cca..923326f 100644 --- a/tests/test_login.py +++ b/tests/test_login.py @@ -10,7 +10,7 @@ PROJECT_ROOT = Path(__file__).resolve().parent.parent sys.path.insert(0, str(PROJECT_ROOT)) from playwright.sync_api import sync_playwright -from utils.auth import login, logout, close_session +from utils.auth import login, logout import os # Load environment variables @@ -31,11 +31,19 @@ print(f" Username: {os.getenv('ERP_USERNAME')}") print(f" Headless: {os.getenv('ERP_HEADLESS')}") print(f" Ignore HTTPS Errors: {os.getenv('ERP_IGNORE_HTTPS_ERRORS')}") +# Construct complete login URL +url = f"{os.getenv('ERP_URL').rstrip('/')}/yonbip/resources/uap/rbac/login/main/index.html" + try: with sync_playwright() as p: print("\n[1/5] Starting browser...") browser, context, page, main_frame = login( playwright=p, + username=os.getenv('ERP_USERNAME'), + password=os.getenv('ERP_PASSWORD'), + url=url, + headless=os.getenv('ERP_HEADLESS', 'false').lower() in ('true', '1', 'yes'), + ignore_https_errors=os.getenv('ERP_IGNORE_HTTPS_ERRORS', 'true').lower() in ('true', '1', 'yes'), verbose=True ) @@ -66,7 +74,8 @@ try: # Close browser print("\n[CLEANUP] Closing browser session...") - close_session(browser, context) + context.close() + browser.close() except Exception as e: print(f"\n[ERROR] Login/logout test failed!")