Refactor strategy pattern to implement separation of concerns

- Update IModuleProcessor interface to accept targetBOMs collection instead of targetItemName string
- Remove filtering logic from strategy implementations (AppendOnly, CloneNew)
- Add LoadData method to mSpecAdditionManager for UI initialization
- Rename ExecuteAddition to ExecutePipeline with refined parameters
- Enhance test suite to simulate fine-grained UI selection behavior
- Enable precise row-level control by delegating filtering to UI layer

This refactoring achieves better separation of concerns where:
- Strategy layer focuses purely on execution logic
- UI layer handles selection and filtering
- Manager layer coordinates the pipeline flow

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Misaka_Company
2026-03-19 15:04:24 +08:00
parent d17d7c5864
commit b73e39eeee
5 changed files with 92 additions and 109 deletions

View File

@@ -167,7 +167,7 @@ End Sub
Private Sub Test_Processors()
Debug.Print ""
Debug.Print "========== 4. 开始测试: 业务策略层 (Strategy) 新架构 =========="
Debug.Print "========== 4. 开始测试: 业务策略层 (Strategy) 细粒度新架构 =========="
Dim engine As cConditionEngine
Set engine = New cConditionEngine
@@ -175,47 +175,45 @@ Private Sub Test_Processors()
Dim paramName As String: paramName = "lcfw"
Dim newValue As String: newValue = "M19"
Dim mockBOMs As New Collection
Dim allBOMs As New Collection
Dim targetBOMs As New Collection
Dim row1 As New cBOMRow, row2 As New cBOMRow, row3 As New cBOMRow
row1.ItemName = "径向高压接头"
row1.Condition = "lcfw=M12"
mockBOMs.Add row1
row1.ItemName = "径向高压接头": row1.Condition = "lcfw=M12": allBOMs.Add row1
row2.ItemName = "径向高压接头": row2.Condition = "lcfw=M13": allBOMs.Add row2
row3.ItemName = "弹簧管": row3.Condition = "lcfw=M01 AND gclj!=M20": allBOMs.Add row3
row2.ItemName = "径向高压接头"
row2.Condition = "lcfw=M13"
mockBOMs.Add row2
row3.ItemName = "弹簧管"
row3.Condition = "lcfw=M01 AND gclj!=M20"
mockBOMs.Add row3
' 【核心逻辑】模拟 UI 层仅将用户勾选的具体行 (比如 row1) 加入 targetBOMs 集合
targetBOMs.Add row1
' 测试 1: 追加策略 (AppendOnly)
Dim strategyAppend As IModuleProcessor
Set strategyAppend = New cProcessor_AppendOnly
strategyAppend.ProcessSpec mockBOMs, "径向高压接头", paramName, newValue, engine
strategyAppend.ProcessSpec allBOMs, targetBOMs, paramName, newValue, engine
AssertEqual "追加策略_变种1被更新", "lcfw=M12 OR lcfw=M19", row1.Condition
AssertEqual "追加策略_变种2被更新", "lcfw=M13 OR lcfw=M19", row2.Condition
AssertEqual "追加策略_选中的变种1被更新", "lcfw=M12 OR lcfw=M19", row1.Condition
AssertEqual "追加策略_未选中的变种2保持不变", "lcfw=M13", row2.Condition
AssertEqual "追加策略_不影响其他物料", "lcfw=M01 AND gclj!=M20", row3.Condition
' 测试 2: 克隆新增策略 (CloneNew)
Dim strategyClone As IModuleProcessor
Set strategyClone = New cProcessor_CloneNew
Dim initialCount As Integer
initialCount = mockBOMs.count
Dim initialCount As Integer: initialCount = allBOMs.count
strategyClone.ProcessSpec mockBOMs, "弹簧管", paramName, newValue, engine
' 模拟 UI 选择弹簧管作为克隆母版
Set targetBOMs = New Collection
targetBOMs.Add row3
AssertEqual "克隆策略_集合数量增加", CStr(initialCount + 1), CStr(mockBOMs.count)
AssertEqual "克隆策略_新行条件纯粹准确", "lcfw=M19", mockBOMs(mockBOMs.count).Condition
AssertEqual "克隆策略_新行名称继承", "弹簧管", mockBOMs(mockBOMs.count).ItemName
strategyClone.ProcessSpec allBOMs, targetBOMs, paramName, newValue, engine
AssertEqual "克隆策略_总库数量增加", CStr(initialCount + 1), CStr(allBOMs.count)
AssertEqual "克隆策略_新行条件纯粹准确", "lcfw=M19", allBOMs(allBOMs.count).Condition
End Sub
' ==============================================================================
' 新增:端到端流水线集成测试
' 验证 Manager 能否将表数据读取、调用策略并正确写回物理单元格
' ==============================================================================
Private Sub Test_Manager_Pipeline()
Debug.Print ""
@@ -225,7 +223,6 @@ Private Sub Test_Manager_Pipeline()
Dim wsTemp As Worksheet
Set wb = ThisWorkbook
' 创建沙盒工作表并准备初始数据
Application.DisplayAlerts = False
On Error Resume Next
wb.Worksheets("BOMForge_Test_Pipeline").Delete
@@ -233,39 +230,25 @@ Private Sub Test_Manager_Pipeline()
Set wsTemp = wb.Worksheets.Add
wsTemp.Name = "BOMForge_Test_Pipeline"
' 表头及数据
wsTemp.Cells(3, 1).value = "行号"
wsTemp.Cells(4, 1).value = 700: wsTemp.Cells(4, 4).value = "径向高压接头": wsTemp.Cells(4, 6).value = "lcfw=M12"
wsTemp.Cells(5, 1).value = 710: wsTemp.Cells(5, 4).value = "径向高压接头": wsTemp.Cells(5, 6).value = "lcfw=M13"
wsTemp.Cells(6, 1).value = 800: wsTemp.Cells(6, 4).value = "弹簧管": wsTemp.Cells(6, 6).value = "lcfw=M01"
' 第4行目标物料1
wsTemp.Cells(4, 1).value = 700
wsTemp.Cells(4, 4).value = "径向高压接头" ' ItemName
wsTemp.Cells(4, 6).value = "lcfw=M12" ' Condition
' 模拟 UI 打开时加载数据
Dim globalBOMs As Collection
Set globalBOMs = mSpecAdditionManager.LoadData(wsTemp)
' 第5行目标物料2 (变种)
wsTemp.Cells(5, 1).value = 710
wsTemp.Cells(5, 4).value = "径向高压接头"
wsTemp.Cells(5, 6).value = "lcfw=M13"
' 模拟 UI 细粒度勾选只选中了第5行 (即集合中的第2个对象)
Dim uiSelectedBOMs As New Collection
uiSelectedBOMs.Add globalBOMs(2)
' 第6行非目标物料
wsTemp.Cells(6, 1).value = 800
wsTemp.Cells(6, 4).value = "弹簧管"
wsTemp.Cells(6, 6).value = "lcfw=M01"
' 执行调度中枢的追加流水线
mSpecAdditionManager.ExecutePipeline wsTemp, globalBOMs, uiSelectedBOMs, "lcfw", "M19", "APPEND"
' ===== 执行调度中枢的追加流水线 =====
mSpecAdditionManager.ExecuteAddition wsTemp, "径向高压接头", "lcfw", "M19", "APPEND"
' 断言 Excel 表格的结果
AssertEqual "集成测试_追加_目标行1已被更新", "lcfw=M12 OR lcfw=M19", wsTemp.Cells(4, 6).value
AssertEqual "集成测试_追加_目标行2已被更新", "lcfw=M13 OR lcfw=M19", wsTemp.Cells(5, 6).value
AssertEqual "集成测试_追加_非目标行保持不变", "lcfw=M01", wsTemp.Cells(6, 6).value
' ===== 执行调度中枢的克隆新增流水线 =====
mSpecAdditionManager.ExecuteAddition wsTemp, "弹簧管", "lcfw", "M19", "CLONE"
' 断言 Excel 表格的结果 (克隆的行应追加在末尾)
AssertEqual "集成测试_克隆_原行保持不变", "lcfw=M01", wsTemp.Cells(6, 6).value
AssertEqual "集成测试_克隆_新增行名称", "弹簧管", wsTemp.Cells(7, 4).value
AssertEqual "集成测试_克隆_新增行条件", "lcfw=M19", wsTemp.Cells(7, 6).value
AssertEqual "流水线_追加_目标行1未选中(不变)", "lcfw=M12", wsTemp.Cells(4, 6).value
AssertEqual "流水线_追加_目标行2被选中更新", "lcfw=M13 OR lcfw=M19", wsTemp.Cells(5, 6).value
AssertEqual "流水线_追加_无关行不变", "lcfw=M01", wsTemp.Cells(6, 6).value
wsTemp.Delete
Application.DisplayAlerts = True