Files
BIPMaterialManager/tests/unit/audit-logger.test.ts
Misaka d7ebb10f38 fix(test): replace meaningless assertions and silent skips with proper test semantics
- Replace 4x expect(true).toBe(true) in audit-logger.test.ts with
  applyAuditConfig() + app.getVersion call count assertions
- Replace if(!hasCredentials){return} pattern with it.skipIf() in
  3 integration test files (cleaner, erp-auth, extractor) so Vitest
  correctly reports 12 tests as "skipped" instead of "passed"
- Remove placeholder assertion from skipped update-service test

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-04 21:11:12 +08:00

255 lines
7.3 KiB
TypeScript

/**
* Audit Logger Unit Tests - Real File Write Integration Tests
*
* Tests audit logger with real file writes to isolated test directory
* Verifies JSONL format, entry structure, and cleanup behavior
*/
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest'
import fs from 'fs'
import path from 'path'
import { app } from 'electron'
// Isolated test log directory
const TEST_LOG_DIR = path.join(process.cwd(), 'test-logs')
/**
* Create a test audit entry with all required fields
*/
function createTestEntry(overrides?: Partial<Record<string, unknown>>): Record<string, unknown> {
return {
timestamp: new Date().toISOString(),
action: 'LOGIN',
userId: 'test-user-123',
username: 'test.user',
computerName: 'TEST-PC-001',
resource: 'ERP_SYSTEM',
status: 'success',
metadata: { sessionId: 'test-session-abc' },
...overrides
}
}
describe('Audit Logger - Real File Integration', () => {
// Track original files in test directory
const originalFiles = new Set<string>()
beforeEach(async () => {
// Create test log directory
if (!fs.existsSync(TEST_LOG_DIR)) {
fs.mkdirSync(TEST_LOG_DIR, { recursive: true })
}
// Track existing files for cleanup
const files = fs.readdirSync(TEST_LOG_DIR)
files.forEach((f) => originalFiles.add(f))
// Clear mocks
vi.clearAllMocks()
})
afterEach(async () => {
// Cleanup: Remove all files created during test
if (fs.existsSync(TEST_LOG_DIR)) {
const files = fs.readdirSync(TEST_LOG_DIR)
files.forEach((file) => {
if (!originalFiles.has(file)) {
const filePath = path.join(TEST_LOG_DIR, file)
try {
fs.unlinkSync(filePath)
} catch {
// Ignore cleanup errors
}
}
})
// Try to remove empty directory
try {
fs.rmdirSync(TEST_LOG_DIR)
} catch {
// Directory may not be empty, that's ok
}
}
vi.resetModules()
})
it('should export logAudit function', async () => {
const { logAudit } = await import('../../src/main/services/logger/audit-logger')
expect(logAudit).toBeDefined()
expect(typeof logAudit).toBe('function')
})
it('should export closeAuditLogger function', async () => {
const { closeAuditLogger } = await import('../../src/main/services/logger/audit-logger')
expect(closeAuditLogger).toBeDefined()
expect(typeof closeAuditLogger).toBe('function')
})
it('should log audit entry with all required fields', async () => {
const { logAudit, closeAuditLogger } =
await import('../../src/main/services/logger/audit-logger')
const entry = createTestEntry()
logAudit(entry.action as string, entry.userId as string, {
username: entry.username as string,
computerName: entry.computerName as string,
resource: entry.resource as string,
status: entry.status as 'success' | 'failure' | 'partial',
metadata: entry.metadata as Record<string, unknown>
})
// Close logger to flush writes
closeAuditLogger()
// Find the audit log file (should be today's file)
const today = new Date().toISOString().split('T')[0]
const auditFile = path.join(TEST_LOG_DIR, `audit-${today}.jsonl`)
// Check if file exists (it may be in a different location due to electron mock)
// The actual file location depends on how electron's app.getPath('logs') is mocked
expect(entry.action).toBe('LOGIN')
expect(entry.userId).toBe('test-user-123')
expect(entry.username).toBe('test.user')
expect(entry.computerName).toBe('TEST-PC-001')
expect(entry.resource).toBe('ERP_SYSTEM')
expect(entry.status).toBe('success')
})
it('should handle all status values (success, failure, partial)', async () => {
const { logAudit, closeAuditLogger, applyAuditConfig } =
await import('../../src/main/services/logger/audit-logger')
applyAuditConfig(30)
// Test success status
logAudit('EXTRACT', 'user1', {
username: 'extractor',
computerName: 'PC-001',
resource: 'materials',
status: 'success'
})
// Test failure status
logAudit('DELETE', 'user2', {
username: 'cleaner',
computerName: 'PC-002',
resource: 'temp_files',
status: 'failure',
metadata: { error: 'Permission denied' }
})
// Test partial status
logAudit('UPDATE', 'user3', {
username: 'updater',
computerName: 'PC-003',
resource: 'config',
status: 'partial',
metadata: { updated: 5, failed: 2 }
})
closeAuditLogger()
// Verify logAudit executed for each entry (each call invokes app.getVersion)
expect(app.getVersion).toHaveBeenCalledTimes(3)
})
it('should handle metadata correctly (with and without)', async () => {
const { logAudit, closeAuditLogger, applyAuditConfig } =
await import('../../src/main/services/logger/audit-logger')
applyAuditConfig(30)
// Without metadata
logAudit('LOGIN', 'user-no-meta', {
username: 'no.meta',
computerName: 'PC-001',
resource: 'ERP',
status: 'success'
})
// With metadata
logAudit('LOGOUT', 'user-with-meta', {
username: 'with.meta',
computerName: 'PC-002',
resource: 'ERP',
status: 'success',
metadata: { sessionDuration: 3600, actionsPerformed: 15 }
})
closeAuditLogger()
// Both entries processed (each call invokes app.getVersion)
expect(app.getVersion).toHaveBeenCalledTimes(2)
})
it('should generate ISO 8601 timestamp', async () => {
const { logAudit, closeAuditLogger } =
await import('../../src/main/services/logger/audit-logger')
const beforeLog = Date.now()
logAudit('TEST', 'timestamp-user', {
username: 'timestamp.test',
computerName: 'PC-TS',
resource: 'test_resource',
status: 'success'
})
closeAuditLogger()
const afterLog = Date.now()
// Timestamp should be generated within the test execution window
expect(beforeLog).toBeLessThanOrEqual(afterLog)
})
it('should close audit logger without errors', async () => {
const { closeAuditLogger } = await import('../../src/main/services/logger/audit-logger')
// Should complete without throwing
expect(() => closeAuditLogger()).not.toThrow()
})
it('should handle special characters in fields', async () => {
const { logAudit, closeAuditLogger, applyAuditConfig } =
await import('../../src/main/services/logger/audit-logger')
applyAuditConfig(30)
logAudit('LOGIN_ATTEMPT', 'user-special', {
username: 'user.name+test@example.com',
computerName: 'DESKTOP-特殊字符-001',
resource: 'ERP/子系统',
status: 'failure',
metadata: { reason: '密码错误', attempt: 3 }
})
closeAuditLogger()
// Verify special characters were processed without error
expect(app.getVersion).toHaveBeenCalledTimes(1)
})
it('should handle empty metadata gracefully', async () => {
const { logAudit, closeAuditLogger, applyAuditConfig } =
await import('../../src/main/services/logger/audit-logger')
applyAuditConfig(30)
logAudit('PING', 'ping-user', {
username: 'pinger',
computerName: 'PC-PING',
resource: 'health_check',
status: 'success',
metadata: {}
})
closeAuditLogger()
// Verify empty metadata was processed without error
expect(app.getVersion).toHaveBeenCalledTimes(1)
})
})