2 Commits

Author	SHA1	Message	Date
Misaka	fc71b2a585	fix(test): replace meaningless assertions with behavior-based tests across 7 test files ... Replace toBeDefined()/typeof checks with assertions that verify actual behavior and output content. Key changes: - locators: assert actual CSS selector values instead of existence - logger-integration: test run()/getContext()/withRequestContext() behavior - logger: verify winstonCalls content (level, message, metadata) - config-manager: test default values, singleton, and getConfig() throws - erp-auth: remove empty Class Structure block (covered by behavior tests) - audit-logger: spy on auditLogger.info to verify JSONL entry content - extractor: remove Math.ceil tests, verify error result structure Net: -209 lines of hollow/redundant test code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-04 22:07:09 +08:00
Misaka	2e102d8ab3	refactor(tests): Move ConfigManager and Update tests to proper locations ... ## Summary: - Create tests/unit/config-manager.test.ts (6 tests) - Move ConfigManager tests from logger.test.ts to dedicated file - Create tests/integration/update-workflow.test.ts (3 tests) - Update skip comments in update-service.test.ts - Reduce skipped tests from 8 to 4 (-50%) ## Results: - Test Files: 42 passed (100%) - Tests: 325 passed, 4 skipped (98.8% execution) - Skipped tests reduced: 8 → 4 - Coverage improved: 97.5% → 98.8% ## Architecture Improvements: - Logger and ConfigManager tests completely separated - Unit tests vs Integration tests responsibilities clarified - Mock strategies clearly defined per file - Skipped tests have clear documentation ## Files Changed: - NEW: tests/unit/config-manager.test.ts - NEW: docs/P2_REFACTOR_SUMMARY.md - NEW: docs/SKIPPED_TESTS_EXPLANATION.md - MODIFIED: tests/unit/logger.test.ts - MODIFIED: tests/unit/update-service.test.ts	2026-04-04 19:13:49 +08:00