From e91b7308a7b7992d4dc519c3290959141668f837 Mon Sep 17 00:00:00 2001 From: Misaka_Company Date: Tue, 14 Apr 2026 10:47:04 +0800 Subject: [PATCH] fix(tests): sync test expectations with current implementation Update dialect tests for UTC timestamp functions and cleaner-handler test for runCleaner's extended parameter signature. Co-Authored-By: Claude Opus 4.6 --- tests/unit/cleaner-handler.test.ts | 23 +++++++++++++++++-- tests/unit/dialects/mysql-dialect.test.ts | 4 ++-- tests/unit/dialects/sqlserver-dialect.test.ts | 4 ++-- 3 files changed, 25 insertions(+), 6 deletions(-) diff --git a/tests/unit/cleaner-handler.test.ts b/tests/unit/cleaner-handler.test.ts index ee21725..e6543e9 100644 --- a/tests/unit/cleaner-handler.test.ts +++ b/tests/unit/cleaner-handler.test.ts @@ -8,11 +8,23 @@ const withErrorHandlingMock = vi.fn(async (handler: () => Promise) => { }) const serviceMethods = { - runCleaner: vi.fn(async (_sender: unknown, input: unknown) => ({ success: true, input })), + runCleaner: vi.fn( + async ( + _sender: unknown, + input: unknown, + _batchId: string, + _historyDao: unknown, + _appVersion: string + ) => ({ success: true, input }) + ), exportResults: vi.fn(async (items: unknown[]) => ({ success: true, total: items.length })) } vi.mock('electron', () => ({ + app: { + isPackaged: false, + getVersion: () => 'test-version' + }, ipcMain: { handle: handleMock } @@ -51,7 +63,14 @@ describe('registerCleanerHandlers', () => { const result = await runHandler?.(event, input) - expect(serviceMethods.runCleaner).toHaveBeenCalledWith(sender, input) + expect(serviceMethods.runCleaner).toHaveBeenCalledTimes(1) + const actualCall = serviceMethods.runCleaner.mock.calls[0] + expect(actualCall[0]).toBe(sender) + expect(actualCall[1]).toEqual(input) + expect(typeof actualCall[2]).toBe('string') // batchId is UUID + expect(actualCall[3]).toBeDefined() // historyDao + expect(actualCall[4]).toBe('test-version') // appVersion + expect(result).toEqual({ success: true, data: { success: true, input } diff --git a/tests/unit/dialects/mysql-dialect.test.ts b/tests/unit/dialects/mysql-dialect.test.ts index 5106c52..6efa950 100644 --- a/tests/unit/dialects/mysql-dialect.test.ts +++ b/tests/unit/dialects/mysql-dialect.test.ts @@ -46,8 +46,8 @@ describe('MySqlDialect', () => { }) describe('currentTimestamp', () => { - it('should return NOW()', () => { - expect(dialect.currentTimestamp()).toBe('NOW()') + it('should return UTC_TIMESTAMP()', () => { + expect(dialect.currentTimestamp()).toBe('UTC_TIMESTAMP()') }) }) diff --git a/tests/unit/dialects/sqlserver-dialect.test.ts b/tests/unit/dialects/sqlserver-dialect.test.ts index 21ad7e1..c1d07eb 100644 --- a/tests/unit/dialects/sqlserver-dialect.test.ts +++ b/tests/unit/dialects/sqlserver-dialect.test.ts @@ -45,8 +45,8 @@ describe('SqlServerDialect', () => { }) describe('currentTimestamp', () => { - it('should return GETDATE()', () => { - expect(dialect.currentTimestamp()).toBe('GETDATE()') + it('should return SYSUTCDATETIME()', () => { + expect(dialect.currentTimestamp()).toBe('SYSUTCDATETIME()') }) })