From 91f29a116703b003e712972bfa6946859f412688 Mon Sep 17 00:00:00 2001
From: Misaka <pengqiangqiang@gmail.com>
Date: Mon, 6 Apr 2026 17:41:36 +0800
Subject: [PATCH] refactor(audit): unify computerName source to cached
 os.hostname()

Export cachedHostname from audit-logger and use it in process-guards,
replacing process.env.COMPUTERNAME so all audit entries use the same value.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/main/bootstrap/process-guards.ts     | 6 +++---
 src/main/services/logger/audit-logger.ts | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/main/bootstrap/process-guards.ts b/src/main/bootstrap/process-guards.ts
index d561f3f..79a3111 100644
--- a/src/main/bootstrap/process-guards.ts
+++ b/src/main/bootstrap/process-guards.ts
@@ -1,6 +1,6 @@
 import { app } from 'electron'
 import logger from '../services/logger/index'
-import { logAudit, closeAuditLogger } from '../services/logger/audit-logger'
+import { logAudit, closeAuditLogger, cachedHostname } from '../services/logger/audit-logger'
 import { AuditAction, AuditStatus } from '../types/audit.types'
 import { serializeError } from '../services/logger/error-utils'
 
@@ -10,7 +10,7 @@ export function setupProcessGuards(): void {
     try {
       logAudit(AuditAction.SYSTEM_CRASH, 'system', {
         username: 'system',
-        computerName: process.env.COMPUTERNAME || 'unknown',
+        computerName: cachedHostname,
         resource: 'main-process',
         status: AuditStatus.FAILURE,
         metadata: { error: err.message, stack: err.stack }
@@ -29,7 +29,7 @@ export function setupProcessGuards(): void {
     try {
       logAudit(AuditAction.SYSTEM_ERROR, 'system', {
         username: 'system',
-        computerName: process.env.COMPUTERNAME || 'unknown',
+        computerName: cachedHostname,
         resource: 'main-process',
         status: AuditStatus.FAILURE,
         metadata: errorMeta
diff --git a/src/main/services/logger/audit-logger.ts b/src/main/services/logger/audit-logger.ts
index 617f8eb..cbceca1 100644
--- a/src/main/services/logger/audit-logger.ts
+++ b/src/main/services/logger/audit-logger.ts
@@ -102,7 +102,7 @@ export function logAudit(
 }
 
 /** Cached hostname — invariant for the app lifecycle */
-const cachedHostname = hostname()
+export const cachedHostname = hostname()
 
 /**
  * Audit log shortcut that auto-resolves the current user context.